Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 6, 2025

This PR prevents the temporarily forced line breaks used for making potential line breaks in SVG in-line expressions from always causing line breaks. The semantics element doesn't have an inferred mrow, so it was missed when looking through its children for the proper breakpoint element.

Resolves issue mathjax/MathJax#3428.

@dpvc dpvc requested a review from zorkow September 6, 2025 18:38
@dpvc dpvc added this to the v4.0.1 milestone Sep 6, 2025
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (afaf1ea) to head (20a5452).
⚠️ Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
ts/output/common/Wrapper.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1346      +/-   ##
===========================================
- Coverage    86.72%   86.71%   -0.01%     
===========================================
  Files          337      337              
  Lines        84145    84146       +1     
  Branches      3140     4769    +1629     
===========================================
  Hits         72971    72971              
+ Misses       11174    11152      -22     
- Partials         0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit c12a9d4 into develop Oct 10, 2025
2 of 3 checks passed
@dpvc dpvc deleted the issue3428 branch October 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants